kwin commented on a change in pull request #4:
URL: 
https://github.com/apache/sling-org-apache-sling-testing-sling-mock-oak/pull/4#discussion_r757799125



##########
File path: pom.xml
##########
@@ -67,27 +67,14 @@
             <artifactId>org.apache.sling.testing.sling-mock.core</artifactId>
             <version>${sling-mock.version}</version>
             <scope>provided</scope>
-            <exclusions>
-                <exclusion>
-                    <groupId>org.apache.jackrabbit</groupId>
-                    <artifactId>jackrabbit-api</artifactId>
-                </exclusion>
-            </exclusions>
         </dependency>
         <dependency>
             <groupId>org.apache.sling</groupId>
             <artifactId>org.apache.sling.testing.sling-mock.core</artifactId>
             <version>${sling-mock.version}</version>
             <classifier>tests</classifier>
             <scope>test</scope>
-            <exclusions>

Review comment:
       I shaded now also the Jackrabbit API (in its new location). I cannot 
think of a scenario where this leads to damage.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to