anchela commented on code in PR #157:
URL: 
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/157#discussion_r1109532007


##########
src/main/java/org/apache/sling/feature/cpconverter/handlers/slinginitialcontent/BundleSlingInitialContentJarEntryExtractor.java:
##########
@@ -70,7 +67,8 @@ class BundleSlingInitialContentJarEntryExtractor {
      */
     void extractAndAddToAssembler(@NotNull 
BundleSlingInitialContentExtractContext context,
                                   @NotNull 
SlingInitialContentBundleEntryMetaData slingInitialContentBundleEntryMetaData,
-                                  @NotNull 
Set<SlingInitialContentBundleEntryMetaData> 
collectedSlingInitialContentBundleEntries) throws IOException, 
ConverterException {
+                                  @NotNull 
Set<SlingInitialContentBundleEntryMetaData> 
collectedSlingInitialContentBundleEntries,
+                                  @NotNull boolean isDefaultContentXmlFile) 
throws IOException, ConverterException {

Review Comment:
   nope it doesn't :)
   sonar will complain about it.....



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to