niekraaijmakers commented on code in PR #157:
URL: 
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/157#discussion_r1109724771


##########
src/main/java/org/apache/sling/feature/cpconverter/handlers/slinginitialcontent/SlingInitialContentBundleEntryMetaDataCollector.java:
##########
@@ -68,6 +80,20 @@ class SlingInitialContentBundleEntryMetaDataCollector {
         this.contentPackage2FeatureModelConverter = 
contentPackage2FeatureModelConverter;
         this.newBundleFile = newBundleFile;
         this.jarFile = context.getJarFile();
+        
+        this.defaultContentXmlFile = new File(this.basePath, 
"defaultContentXml.xml");

Review Comment:
   We could rename it.. basically its .content.xml file with sling:Folder as 
jcr:primaryType. We put it in sling initial content if there is no 
specification.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to