anchela commented on code in PR #157:
URL: 
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/157#discussion_r1109749305


##########
src/main/java/org/apache/sling/feature/cpconverter/handlers/slinginitialcontent/SlingInitialContentBundleEntryMetaDataCollector.java:
##########
@@ -68,6 +80,20 @@ class SlingInitialContentBundleEntryMetaDataCollector {
         this.contentPackage2FeatureModelConverter = 
contentPackage2FeatureModelConverter;
         this.newBundleFile = newBundleFile;
         this.jarFile = context.getJarFile();
+        
+        this.defaultContentXmlFile = new File(this.basePath, 
"defaultContentXml.xml");

Review Comment:
   and .content.xml does not work? or what is the reason?
   in either case: i would recommend to then add some comment into the xml file 
indicating that this was injected by the converter.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to