anchela commented on code in PR #157:
URL:
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/157#discussion_r1109690361
##########
src/main/java/org/apache/sling/feature/cpconverter/handlers/slinginitialcontent/SlingInitialContentBundleEntryMetaDataCollector.java:
##########
@@ -51,15 +59,19 @@ class SlingInitialContentBundleEntryMetaDataCollector {
private static final double THRESHOLD_RATIO = 10;
private static final int BUFFER = 512;
private static final long TOOBIG = 0x6400000; // Max size of unzipped
data, 100MB
+ static final ClassLoader CL =
SlingInitialContentBundleEntryMetaDataCollector.class.getClassLoader();
Review Comment:
it's only used here. make it private.
##########
src/main/java/org/apache/sling/feature/cpconverter/handlers/slinginitialcontent/SlingInitialContentBundleEntryMetaDataCollector.java:
##########
@@ -68,6 +80,20 @@ class SlingInitialContentBundleEntryMetaDataCollector {
this.contentPackage2FeatureModelConverter =
contentPackage2FeatureModelConverter;
this.newBundleFile = newBundleFile;
this.jarFile = context.getJarFile();
+
+ this.defaultContentXmlFile = new File(this.basePath,
"defaultContentXml.xml");
Review Comment:
i don't remember having ever seen the name `defaultContentXml` in the
context of content packages. is this related to sling-initial content?
if not and this is something you just need here, i would be great if you
could add a comment elaborating what this is used for.
##########
src/main/java/org/apache/sling/feature/cpconverter/handlers/slinginitialcontent/SlingInitialContentBundleEntryMetaDataCollector.java:
##########
@@ -68,6 +80,20 @@ class SlingInitialContentBundleEntryMetaDataCollector {
this.contentPackage2FeatureModelConverter =
contentPackage2FeatureModelConverter;
this.newBundleFile = newBundleFile;
this.jarFile = context.getJarFile();
+
+ this.defaultContentXmlFile = new File(this.basePath,
"defaultContentXml.xml");
Review Comment:
below you use the string 'default-content.xml'
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
