Wonderful!
Yes, I will do the renaming at my codebase and then attaching the code
to the Jira issue. This also makes it easier for me to send the patches
as the names are equal.
Best,
Sandro
Am 01.10.14 17:22, schrieb Carsten Ziegeler:
+1 to accept the contribution
I guess we can sort out all technical issues once the contribution is done.
However, I think the renaming should be done before so we can vote on a
renamed source code base
Carsten
2014-10-01 16:24 GMT+02:00 Sandro Boehme <sandro.boe...@gmx.de>:
Hi Dominik,
thanks for your feedback! Please see my comments inline:
Am 01.10.14 15:17, schrieb Dominik Süß:
Hi everyone,
here my 2 cents about changes that I would like to see (had a short chat
with Sandro at adaptTo() about that):
* rename it and get rid of JCR in the name since it effectively is a
resourceTreeBrowser
As I wrote in my original proposal I would like to rename the JCRBrowser
based on your hint at adaptTo(). I would like to keep it simple and name it
Sling Editor and to have a real name I thought about "Sedi" but it is in
use and the domains are taken. This is why I prefer "Sledi" now. It is
harder to pronounce but still uses the first chars of 'Sling Editor'. But
I'm still open for other suggestions.
* make sure to be compatible with all ResourceProviders through CRUD API
(and blend out operations not available for ResourceProviders not
supporting it)
For changing content I use the Sling POST servlet. I think this is
compatible with the ResourceProviders right?
* get rid of the Selectorbased ResourceDecorator pattern for the browser
but implement a ResourceProvider which does the decorationion to make sure
code can be properly secured for production instances and does not impact
rendering of 3rd code at all.
You are right, the selector could not be used in the application anymore
because this would call the Sling JCRBrowser.
I will find out how ResourceProvider/-Resolver work to change the tool
accordingly.
Best,
Sandro
If all of those points are met I guess this could really be something
useful (especially when not basing on commercial varations that provide a
browser) which can be included without having to worry that it actually
interfers with the application.
Cheers
Dominik
On Wed, Oct 1, 2014 at 3:06 PM, Sandro Boehme <sandro.boe...@gmx.de>
wrote:
Hi Bertrand,
Am 01.10.14 14:43, schrieb Bertrand Delacretaz:
Hi Sandro,
On Wed, Oct 1, 2014 at 2:36 PM, Sandro Boehme <sandro.boe...@gmx.de>
wrote:
...To provide Apache Sling with a content editor like the JCRBrowser I
would
like to know what is needed to contribute the JCRBrowser to Sling. I
could
for example understand if more features are needed...
IIUC your JCRBrowser is read-only at the moment?
beside showing content the Sling JCRBrowser can rename nodes and delete
single nodes and a list of selected nodes.
If yes adding create/update/delete functionality would be nice of
course, but I'm in favor of accepting your contribution in its present
state so that you can benefit from this community's feedback to evolve
it.
As you're not a committer for now you'd need to submit patches to
expand it, but that's the best way to become a committer, by showing
us how you work and communicate based on a real project.
I'm absolutely fine with submitting patches.
So IMO we should accept this contribution now (in contrib - not core
for now) - what do others think?
-Bertrand
Best,
Sandro
