[
https://issues.apache.org/jira/browse/SLING-5035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14802973#comment-14802973
]
Radu Cotescu commented on SLING-5035:
-------------------------------------
Sure, but we're comparing 1.2.2 with 1.0.0 - we already know that 1.x.y (where
x > 0) introduces API changes. I think that it's better to implement the
Injectors picking algorithm to comply with the OSGi principles than to have
this weird behaviour.
Also, taking into account the current ordering, it doesn't make sense to have
the Script Bindings injector called before anything else, which basically hints
at the fact that the implementation was wrong from the beginning.
> Sling Models Injectors should be queried in the reverse order of their
> service ranking value
> --------------------------------------------------------------------------------------------
>
> Key: SLING-5035
> URL: https://issues.apache.org/jira/browse/SLING-5035
> Project: Sling
> Issue Type: Bug
> Components: Extensions
> Affects Versions: Sling Models Impl 1.2.2
> Reporter: Radu Cotescu
> Fix For: Sling Models Impl 1.2.4
>
>
> The current version of the {{ModelAdaptorFactory}} \[0\] queries the
> Injectors in the ascending order of their service ranking value. However they
> should be queried in the descending order of the service ranking, to use the
> same logic as the {{BundleContext#getServiceReference(String)}} method \[1\].
> \[0\] -
> https://github.com/apache/sling/blob/f56b444b765beb1c31eed01b4c09fbda4013a580/bundles/extensions/models/impl/src/main/java/org/apache/sling/models/impl/ModelAdapterFactory.java#L411
> \[1\] -
> https://osgi.org/javadoc/r4v42/org/osgi/framework/BundleContext.html#getServiceReference(java.lang.String)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
