[
https://issues.apache.org/jira/browse/SLING-5035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14802983#comment-14802983
]
Stefan Seifert commented on SLING-5035:
---------------------------------------
bq. Also, taking into account the current ordering, it doesn't make sense to
have the Script Bindings injector called before anything else, which basically
hints at the fact that the implementation was wrong from the beginning.
i don't think so. the current - effective - order is documented also here
http://sling.apache.org/documentation/bundles/models.html#available-injectors
all new injectors since 1.1 were added at the end. the 1.0 injectors starting
with script bindings at first position were designed in this order by justin,
and i assume he had good reasons for it.
changing this order now breaks the API contract and thus would need a 2.x
version number.
> Sling Models Injectors should be queried in the reverse order of their
> service ranking value
> --------------------------------------------------------------------------------------------
>
> Key: SLING-5035
> URL: https://issues.apache.org/jira/browse/SLING-5035
> Project: Sling
> Issue Type: Bug
> Components: Extensions
> Affects Versions: Sling Models Impl 1.2.2
> Reporter: Radu Cotescu
> Fix For: Sling Models Impl 1.2.4
>
>
> The current version of the {{ModelAdaptorFactory}} \[0\] queries the
> Injectors in the ascending order of their service ranking value. However they
> should be queried in the descending order of the service ranking, to use the
> same logic as the {{BundleContext#getServiceReference(String)}} method \[1\].
> \[0\] -
> https://github.com/apache/sling/blob/f56b444b765beb1c31eed01b4c09fbda4013a580/bundles/extensions/models/impl/src/main/java/org/apache/sling/models/impl/ModelAdapterFactory.java#L411
> \[1\] -
> https://osgi.org/javadoc/r4v42/org/osgi/framework/BundleContext.html#getServiceReference(java.lang.String)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
