[ 
https://issues.apache.org/jira/browse/SLING-4352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14934764#comment-14934764
 ] 

Dirk Rudolph commented on SLING-4352:
-------------------------------------

What about adding a ResourceResolverWrapper to both API and servlet resolver 
marking the second one as deprecated and switching to the API one when the 
dependency to the API gets updated next time?

I'm not completely sure about the use of reflection in that use case and the 
overhead it introduces for just replacing one method. 

> The ResourceResolver passed to SlingScripts should not be closeable
> -------------------------------------------------------------------
>
>                 Key: SLING-4352
>                 URL: https://issues.apache.org/jira/browse/SLING-4352
>             Project: Sling
>          Issue Type: Bug
>          Components: Servlets
>            Reporter: Radu Cotescu
>            Assignee: Carsten Ziegeler
>             Fix For: Servlets Resolver 2.3.8
>
>
> The {{SlingServletResolver}} uses an administrative resource resolver 
> ({{sharedScriptResolver}}) for script resolution. This same resolver is 
> passed to SlingScripts when a resource is adapted to a {{SlingScript}} in 
> {{SlingServletResolver#findScript}} (see 
> {{SlingScriptAdapterFactory#getAdapter}}).
> Since this resolver is made available to scripts in the {{ScriptContext}} 
> (see the implementation of {{DefaultSlingScript#call}}), the resolver should 
> be protected against accidental closing from downstream callers.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to