[
https://issues.apache.org/jira/browse/SLING-4352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14936513#comment-14936513
]
Carsten Ziegeler commented on SLING-4352:
-----------------------------------------
While trying to implement this I noticed that a proxy (or wrapper) is not
sufficient. We would need to wrap each and every resource returned as well.
Otherwise the real resource resolver leaks through any resource returned by it.
I'm wondering if all this is really worth the effort. For reference I've
attached a patch for creating the proxy (not sure if it's complete though)
> The ResourceResolver passed to SlingScripts should not be closeable
> -------------------------------------------------------------------
>
> Key: SLING-4352
> URL: https://issues.apache.org/jira/browse/SLING-4352
> Project: Sling
> Issue Type: Bug
> Components: Servlets
> Reporter: Radu Cotescu
> Assignee: Carsten Ziegeler
> Fix For: Servlets Resolver 2.3.8
>
>
> The {{SlingServletResolver}} uses an administrative resource resolver
> ({{sharedScriptResolver}}) for script resolution. This same resolver is
> passed to SlingScripts when a resource is adapted to a {{SlingScript}} in
> {{SlingServletResolver#findScript}} (see
> {{SlingScriptAdapterFactory#getAdapter}}).
> Since this resolver is made available to scripts in the {{ScriptContext}}
> (see the implementation of {{DefaultSlingScript#call}}), the resolver should
> be protected against accidental closing from downstream callers.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
