Sounds like it isn't necessarily a showstopper - I guess Robert has to make the call if he wants to cancel the release or have it pass.
FWIW, I would have liked to have the latest servlets.post 2.3.24 release included as well so if we respin the release we might include it as well :-). regards, Karl On Tue, Jan 23, 2018 at 11:37 AM, Radu Cotescu <[email protected]> wrote: > Hi Karl, > > A project deployed on the Sling 10 Starter that would use i18n with a > resource bundle provider that should take into account the basename > requested by the client might fail to get the correct translation. > > Cheers, > Radu > > On Tue, 23 Jan 2018 at 12:17 Karl Pauls <[email protected]> wrote: > >> Hi Radu, >> >> what is the impact of this bug (mostly want to find out if it breaks >> us in a major way or if it is just a special case)? >> >> regards, >> >> Karl >> >> On Tue, Jan 23, 2018 at 11:01 AM, Radu Cotescu <[email protected]> wrote: >> > -1. See >> > >> https://issues.apache.org/jira/browse/SLING-6952?focusedCommentId=16335586&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16335586 >> > . >> > >> > Sorry for this... :( >> > >> > Radu >> > >> > On Mon, 22 Jan 2018 at 23:16 Karl Pauls <[email protected]> wrote: >> > >> >> +1 >> >> >> >> regards, >> >> >> >> Karl >> >> >> >> On Fri, Jan 19, 2018 at 6:24 PM, Robert Munteanu <[email protected]> >> >> wrote: >> >> > Hi, >> >> > >> >> > Update note: I've chosen to respin the Starter release with the same >> >> > version, for 2 reasons: >> >> > >> >> > - it would generate confusion to skip a release >> >> > - chances of anyone depending on the staged slingstart are slim >> >> > >> >> > If anyone thinks otherwise, I'll restart the release vote as Sling 11. >> >> > ---- >> >> > >> >> > Time to release Sling 10. This year I've added all the testing >> >> > projects, to retain what was working at the time of the release and >> the >> >> > archetypes, to allow users to start using the new features immediately >> >> > rather than releasing them separately. >> >> > >> >> > This has lead to a rather large release though. >> >> > >> >> > The following artifacts, with the associated changelogs, are included >> >> > in this release >> >> > >> >> > - Apache Sling Starter 10 >> >> > https://issues.apache.org/jira/projects/SLING/versions/12340941 (13 >> >> issues) >> >> > >> >> > - Apache Sling Launchpad Testing 10 >> >> > https://issues.apache.org/jira/projects/SLING/versions/12317575 (33 >> >> issues) >> >> > >> >> > - Apache Sling Launchpad Testing WAR 10 >> >> > https://issues.apache.org/jira/projects/SLING/versions/12342164 (0 >> >> issues) >> >> > >> >> > - Apache Sling Launchpad Integration Tests 1.0.6 >> >> > https://issues.apache.org/jira/projects/SLING/versions/12341715 (0 >> >> issues) >> >> > >> >> > - Apache Sling Launchpad Test Bundles 0.0.4 (no changelog) >> >> > - Apache Sling Launchpad Testing Fragment Bundle 2.0.14 (no changelog) >> >> > >> >> > - Apache Sling Launchpad Testing Services 2.0.14 >> >> > https://issues.apache.org/jira/projects/SLING/versions/12338823 (2 >> >> issues) >> >> > >> >> > - Apache Sling Launchpad Testing Services WAR 2.0.14 (no changelog) >> >> > >> >> > - Apache Sling Archetype Parent 5 >> >> > https://issues.apache.org/jira/projects/SLING/versions/12333898 (2 >> >> issues) >> >> > >> >> > - Apache Sling Bundle Archetype 1.0.6 >> >> > https://issues.apache.org/jira/browse/SLING/fixforversion/12333900 (2 >> >> issues) >> >> > >> >> > - Apache Sling JCRInstall Bundle Archetype 1.0.6 >> >> > https://issues.apache.org/jira/browse/SLING/fixforversion/12333901 (2 >> >> issues) >> >> > >> >> > - Apache Sling Initial Content Archetype 1.0.6 >> >> > https://issues.apache.org/jira/browse/SLING/fixforversion/12333902 (2 >> >> issues) >> >> > >> >> > - Apache Sling Slingstart Archetype 1.0.6 >> >> > https://issues.apache.org/jira/browse/SLING/fixforversion/12340954 (2 >> >> issues) >> >> > >> >> > Staging repositories: >> >> > >> https://repository.apache.org/content/repositories/orgapachesling-1857 >> >> > >> https://repository.apache.org/content/repositories/orgapachesling-1858 >> >> > >> >> > You can use this UNIX script to download the release and verify the >> >> > signatures: >> >> > >> >> >> https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD >> >> > >> >> > Usage: >> >> > sh check_staged_release.sh 1857 /tmp/sling-stagingsh >> >> check_staged_release.sh 1858 /tmp/sling-staging >> >> > >> >> > Please vote to approve this release: >> >> > >> >> > [ ] +1 Approve the release >> >> > [ ] 0 Don't care >> >> > [ ] -1 Don't release, because ... >> >> > >> >> > This majority vote is open for at least 72 hours, but I'd be more than >> >> > happy to allow extensions if anyone needs more time to validate the >> >> > release. >> >> > >> >> > Thanks, >> >> > >> >> > Robert >> >> > >> >> >> >> >> >> >> >> -- >> >> Karl Pauls >> >> [email protected] >> >> >> >> >> >> -- >> Karl Pauls >> [email protected] >> -- Karl Pauls [email protected]
