https://issues.apache.org/SpamAssassin/show_bug.cgi?id=5752


Daryl C. W. O'Shea <[EMAIL PROTECTED]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[EMAIL PROTECTED]




--- Comment #14 from Daryl C. W. O'Shea <[EMAIL PROTECTED]>  2008-03-18 
01:53:26 PST ---
r637451 needs thorough review, I don't think anything but the new functionality
was tested.  For instance, running sa-update without --install is currently
broken. :(

There are if statements checking for $opt{'install'} that should really be
checking for @{$opt{'install'}}.

I haven't tried it, but I don't see anything (although it is 4:50am) that
prevents you from trying to do both an --install and a regular --channel update
which, depending on what order you specify stuff, could work (if the non
--install --channelS are listed last) or could royally screw up (if you say,
and mean, --channel ... --channel ... --install ...) what versions sa-update
thinks are installed of each of the channels (not to mention they'd have the
wrong data).

Also, if you're going to allow multiple updates to be --install'd at once
(suggesting multiple channel source file sources) the requirement for 6 digits
in the source files seems rather arbitrary.


I think we're best off in the user-confusion-ability department by only
allowing one channel to be --install'ed at a time (or at least not allowing
regular channel updates simultaneously).


-- 
Configure bugmail: 
https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

Reply via email to