https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6724

--- Comment #27 from Kevin A. McGrail <[email protected]> 2011-12-14 19:42:48 
UTC ---
(In reply to comment #25)
> Implemented RCVD_IN_DNSWL_BLOCKED. Disabled by zero score override for now,
> just like the other DNSWL rules. To be enabled when bug 6718 gets reverted.

I'm pleased with Matthias' comments in #23 and I believe other PMC members are
as well.

Matthias, are those changes implemented so we can re-enabled DNSWL?

> 50_scores.cf: Moved the score lines for URIBL and DNSWL BLOCKED rules into
> their respective, existing (ifplugin guarded) sections. Scores now set for
> individual score-sets. Same for URIBL_RED.
> 
> 25_uribl.cf: Fixed description, escaped the anchor hash in the URI. Added 
> reuse
> option for URIBL_BLOCKED.
> 
> rulesrc/10_force_active.cf: Force publish the BLOCKED rules.
> 
> Committed revision 1214333.

Other than taking out the nice flag which I agreed with comments above likely
shouldn't exist, looks good to me.  I am unsure if setting a score in
50_scores.cf AND the forcepublish is needed for 25_uribl.cf rules but I can't
see how it hurts.  I was planning to do the same thing.

svn commit -m 'Removed nice flag on _BLOCKED rules'
Sending        rules/25_uribl.cf
Sending        rulesrc/sandbox/felicity/70_dnswl.cf

> 
> The DNSWL rules file 70_dnswl.cf probably should be moved out of the sandbox
> eventually.

I could make this argument for all of the sandbox rules that are published but
that's a higher-level issue than for this ticket.

-- 
Configure bugmail: 
https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

Reply via email to