https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8193

Sidney Markowitz <sid...@sidney.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |---

--- Comment #18 from Sidney Markowitz <sid...@sidney.com> ---
(In reply to Henrik Krohns from comment #17) 
> Not sure if you can even score subrules.

>From Mail::SpamAssassin::Conf POD

"Note that test names which begin with '__' are indirect rules used to compose
meta-match rules and can also act as prerequisites to other rules. They are not
scored or listed in the 'tests hit' reports, but assigning a score of 0 to an
indirect rule will disable it from running."

So you can't score them in the sense of the scores being actually evaluated,
but you can set them to 0 to disable. And by trying it I found that an explicit
non-zero score has the same effect you get from the default 1.0, that the rule
is enabled but the score is ignored. That becomes important if someone wants to
override the rule score being set to 0 in 50_scores.cf

> 
> Isn't this whole thing made too complex? If something is not supposed to be
> in default ruleset and active, shouldn't it just be completely removed? No
> one is going to read 50_scores.cf comments anyway for instructions.

The issue I have is how to handle this using only rule updates so that it takes
effect without requiring a new release that people install. Do you think it
would be better to remove the rules/25_dnswl.cf and the DNSWL scores from
rules/50_scores.cf completely and just document how to add DNSWL rules? I guess
that's just about the same work for the sysadmin as enabling the rules when
they are listed with scores of 0, and that is a simpler change.

-- 
You are receiving this mail because:
You are the assignee for the bug.

Reply via email to