----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23514/#review47807 -----------------------------------------------------------
I think some of the work you did is specific to wallets (getting username from the DB rather than the parameters) and some is for using TNSNAMES (the whole thing with parsing JDBC URLS). But it looks like right now if I use TNSNAMES in my JDBC URL, you will assume that I'm using wallets. I'm wondering if we can remove this assumption and support general TNSNAMES URLs? src/java/org/apache/sqoop/manager/oracle/OraOopJdbcUrl.java <https://reviews.apache.org/r/23514/#comment84027> This would be: "\tjdbc:oracle:<driver-type>:@<host>:<port>/<sid>\n" More important, the extra case you added is for specifying just a TNSNAMES entry, so an example would be: "\tjdbc:oracle:<driver-type>:@<tns_entry>\n" src/java/org/apache/sqoop/manager/oracle/OraOopJdbcUrl.java <https://reviews.apache.org/r/23514/#comment84028> Add a comment with the format you are processing here? Like the ones we have for case 6 and 5? I find them useful. - Gwen Shapira On July 15, 2014, 6:19 p.m., Venkat Ranganathan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23514/ > ----------------------------------------------------------- > > (Updated July 15, 2014, 6:19 p.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-1358 > https://issues.apache.org/jira/browse/SQOOP-1358 > > > Repository: sqoop-trunk > > > Description > ------- > > Added support to understand wallet based JDBC URLS that was done to standard > Oracle connector. This was done earlier in the HWX repo. > > Made sure no new checkstyle violations exist > > > Diffs > ----- > > src/java/org/apache/sqoop/manager/oracle/OraOopConnManager.java 302849c > src/java/org/apache/sqoop/manager/oracle/OraOopConstants.java 874ef02 > src/java/org/apache/sqoop/manager/oracle/OraOopJdbcUrl.java 8502b79 > src/java/org/apache/sqoop/manager/oracle/OraOopManagerFactory.java fcf4a4d > src/java/org/apache/sqoop/manager/oracle/OraOopUtilities.java 473a5ae > > Diff: https://reviews.apache.org/r/23514/diff/ > > > Testing > ------- > > Created Oracle wallet as described in > https://blogs.apache.org/sqoop/entry/using_oracle_wallets_with_sqoop > > Used the wallet in a sqoop job with --direct passed to the command line > arguments to make use of the high performance connector and validated it. > > > Thanks, > > Venkat Ranganathan > >
