-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23514/
-----------------------------------------------------------
(Updated July 17, 2014, 6:06 a.m.)
Review request for Sqoop.
Changes
-------
Removed duplicated code (which incidentally had the one less space issue on a
line) and cleaned up imports. Throw runtime exception in the rare event that
an Oracle function fails to get the current logged on user. Validated with
tests using wallets and TNS entry.
Also, this patch has changes to the documentation about the support for TNS URL
format.
Bugs: SQOOP-1358
https://issues.apache.org/jira/browse/SQOOP-1358
Repository: sqoop-trunk
Description
-------
Added support to understand wallet based JDBC URLS that was done to standard
Oracle connector. This was done earlier in the HWX repo.
Made sure no new checkstyle violations exist
Diffs (updated)
-----
src/docs/user/connectors.txt c04900f
src/java/org/apache/sqoop/manager/OracleManager.java 32cb303
src/java/org/apache/sqoop/manager/oracle/OraOopConnManager.java 302849c
src/java/org/apache/sqoop/manager/oracle/OraOopConstants.java 874ef02
src/java/org/apache/sqoop/manager/oracle/OraOopJdbcUrl.java 8502b79
src/java/org/apache/sqoop/manager/oracle/OraOopManagerFactory.java fcf4a4d
src/java/org/apache/sqoop/manager/oracle/OraOopUtilities.java 473a5ae
Diff: https://reviews.apache.org/r/23514/diff/
Testing
-------
Created Oracle wallet as described in
https://blogs.apache.org/sqoop/entry/using_oracle_wallets_with_sqoop
Used the wallet in a sqoop job with --direct passed to the command line
arguments to make use of the high performance connector and validated it.
Thanks,
Venkat Ranganathan
