----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23514/#review47935 -----------------------------------------------------------
Awesome stuff. Just a nit and a thought. src/java/org/apache/sqoop/manager/oracle/OraOopConnManager.java <https://reviews.apache.org/r/23514/#comment84169> Nit: Watch spacing src/java/org/apache/sqoop/manager/oracle/OraOopUtilities.java <https://reviews.apache.org/r/23514/#comment84171> Is it possible for oracleConnectionUserName to ever be null? currentSessionUser is set by the OraOopManager.getSessionUser(connection) method. This method can be null if there were any problems in communicating with the database. Then, the following code: username.toUpperCase() would fail with a NPE. Then the expectation would be to set the username in tableString? We could add some logging or better exception handling around this case if it is indeed possible to hit. Not sure about this one! - Abraham Elmahrek On July 16, 2014, 7:01 p.m., Venkat Ranganathan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23514/ > ----------------------------------------------------------- > > (Updated July 16, 2014, 7:01 p.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-1358 > https://issues.apache.org/jira/browse/SQOOP-1358 > > > Repository: sqoop-trunk > > > Description > ------- > > Added support to understand wallet based JDBC URLS that was done to standard > Oracle connector. This was done earlier in the HWX repo. > > Made sure no new checkstyle violations exist > > > Diffs > ----- > > src/java/org/apache/sqoop/manager/oracle/OraOopConnManager.java 302849c > src/java/org/apache/sqoop/manager/oracle/OraOopConstants.java 874ef02 > src/java/org/apache/sqoop/manager/oracle/OraOopJdbcUrl.java 8502b79 > src/java/org/apache/sqoop/manager/oracle/OraOopManagerFactory.java fcf4a4d > src/java/org/apache/sqoop/manager/oracle/OraOopUtilities.java 473a5ae > > Diff: https://reviews.apache.org/r/23514/diff/ > > > Testing > ------- > > Created Oracle wallet as described in > https://blogs.apache.org/sqoop/entry/using_oracle_wallets_with_sqoop > > Used the wallet in a sqoop job with --direct passed to the command line > arguments to make use of the high performance connector and validated it. > > > Thanks, > > Venkat Ranganathan > >
