> On July 15, 2014, 8:23 p.m., Gwen Shapira wrote: > > I think some of the work you did is specific to wallets (getting username > > from the DB rather than the parameters) and some is for using TNSNAMES (the > > whole thing with parsing JDBC URLS). But it looks like right now if I use > > TNSNAMES in my JDBC URL, you will assume that I'm using wallets. I'm > > wondering if we can remove this assumption and support general TNSNAMES > > URLs?
Even though it is called a wallet name, it is actually the TNS service name that we are using here. If you don't have a wallet with the credentials, you can still pass username and passwords with this URL format. There is nothing precluding the use of a TNS service name or a complete TNS description in the URL. That is, you can pass the service name (the name you give to a TNS entry with (DESCRIPTION(...)) in the tnsnames.ora or you can actually pass the TNS description itself on the URL itself. Of course, providing the TNS description (instead of the service name) in the URL instead of a service name will mean that your wallet may not be picked up. One more thing about this. This has not been tested on a RAC environment (and probably needs more work). That said, it is good to have the references to wallet changed to TNS . I will update the reference from wallet to tns service name in the next update. > On July 15, 2014, 8:23 p.m., Gwen Shapira wrote: > > src/java/org/apache/sqoop/manager/oracle/OraOopJdbcUrl.java, line 114 > > <https://reviews.apache.org/r/23514/diff/1/?file=632635#file632635line114> > > > > This would be: > > "\tjdbc:oracle:<driver-type>:@<host>:<port>/<sid>\n" > > > > More important, the extra case you added is for specifying just a > > TNSNAMES entry, so an example would be: > > "\tjdbc:oracle:<driver-type>:@<tns_entry>\n" > > Yes. When I copied the contents from our private repo, I had to reformat and copied the same line twice. Thanks > On July 15, 2014, 8:23 p.m., Gwen Shapira wrote: > > src/java/org/apache/sqoop/manager/oracle/OraOopJdbcUrl.java, line 183 > > <https://reviews.apache.org/r/23514/diff/1/?file=632635#file632635line183> > > > > Add a comment with the format you are processing here? Like the ones we > > have for case 6 and 5? I find them useful. Sure - Venkat ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23514/#review47807 ----------------------------------------------------------- On July 15, 2014, 6:19 p.m., Venkat Ranganathan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23514/ > ----------------------------------------------------------- > > (Updated July 15, 2014, 6:19 p.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-1358 > https://issues.apache.org/jira/browse/SQOOP-1358 > > > Repository: sqoop-trunk > > > Description > ------- > > Added support to understand wallet based JDBC URLS that was done to standard > Oracle connector. This was done earlier in the HWX repo. > > Made sure no new checkstyle violations exist > > > Diffs > ----- > > src/java/org/apache/sqoop/manager/oracle/OraOopConnManager.java 302849c > src/java/org/apache/sqoop/manager/oracle/OraOopConstants.java 874ef02 > src/java/org/apache/sqoop/manager/oracle/OraOopJdbcUrl.java 8502b79 > src/java/org/apache/sqoop/manager/oracle/OraOopManagerFactory.java fcf4a4d > src/java/org/apache/sqoop/manager/oracle/OraOopUtilities.java 473a5ae > > Diff: https://reviews.apache.org/r/23514/diff/ > > > Testing > ------- > > Created Oracle wallet as described in > https://blogs.apache.org/sqoop/entry/using_oracle_wallets_with_sqoop > > Used the wallet in a sqoop job with --direct passed to the command line > arguments to make use of the high performance connector and validated it. > > > Thanks, > > Venkat Ranganathan > >
