[ 
https://issues.apache.org/jira/browse/SQOOP-1551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14162198#comment-14162198
 ] 

Veena Basavaraj commented on SQOOP-1551:
----------------------------------------

https://reviews.apache.org/r/26419/diff/1/?page=1 

this RB only addresses #1. renaming the repository upgrader to config upgrader 

> Repository Upgrader api - Extensibility
> ---------------------------------------
>
>                 Key: SQOOP-1551
>                 URL: https://issues.apache.org/jira/browse/SQOOP-1551
>             Project: Sqoop
>          Issue Type: Sub-task
>            Reporter: Veena Basavaraj
>            Assignee: Veena Basavaraj
>
> I am not sure if the current api is extensible enough. It only supports 
> upgrading the config info. Which actually can be now done via the rest api as 
> well. So do we really need this config upgrade api was my first thought?
> I am also not sure how this code supports upgrades across different versions, 
> since there seems to be no code in any of these that has knowledge of the 
> repository version and what type of repository it really belongs to
> Split the api into
> ConnectorConfigUpgrader
> upgradeLinkConfig
> upgradeFromJobConfig
> upgradeToJobConfig
> DriverConfig Upgrader
> upgradeDriverConfig



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to