[
https://issues.apache.org/jira/browse/SQOOP-1551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14177393#comment-14177393
]
Veena Basavaraj commented on SQOOP-1551:
----------------------------------------
Final patch
#2 - + 1 from Jarek Jarcec Cecho as well, if we can come up with a upgrade api
to support different types.
Alternative have a upgrader api per Configurable.
ConnectorConfigUpgrader ( as a base class) with upgradeLink, upgradeFrom,
upgradeTo
DriverConfigUpgrader ( as a a base class )with upgradeJobConfig and later on
add things if we have more config types
Jarek Jarcec Cecho prefers one api though and that is something I might go for
I retracted back to what I proposed earlier, having separate apis per
configurable. Adding a base class also means that every configurable need not
implement every upgrader methods.
> Repository Upgrader api - Extensibility
> ---------------------------------------
>
> Key: SQOOP-1551
> URL: https://issues.apache.org/jira/browse/SQOOP-1551
> Project: Sqoop
> Issue Type: Sub-task
> Affects Versions: 1.99.4
> Reporter: Veena Basavaraj
> Assignee: Veena Basavaraj
> Attachments: SQOOP-1551.patch, SQOOP-1551.patch, SQOOP-1551.patch
>
>
> I am not sure if the current api is extensible enough. It only supports
> upgrading the config info. Which actually can be now done via the rest api as
> well. So do we really need this config upgrade api was my first thought?
> I am also not sure how this code supports upgrades across different versions,
> since there seems to be no code in any of these that has knowledge of the
> repository version and what type of repository it really belongs to
> Split the api into
> ConnectorConfigUpgrader
> upgradeLinkConfig
> upgradeFromJobConfig
> upgradeToJobConfig
> DriverConfig Upgrader
> upgradeDriverConfig
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
