[
https://issues.apache.org/jira/browse/SQOOP-1551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14176493#comment-14176493
]
Veena Basavaraj commented on SQOOP-1551:
----------------------------------------
The latest patch addresses both part 1 and part 2. The new upgrade api takes
the config type as an argument and leaves it to the configurables to decide how
to handle each type.
At this point, it is very generic, both the LINK and JOB config type upgrades
are handled pretty much the same, hence the code is moved to a util class to
avoid the copy paste in multiple configurables.
> Repository Upgrader api - Extensibility
> ---------------------------------------
>
> Key: SQOOP-1551
> URL: https://issues.apache.org/jira/browse/SQOOP-1551
> Project: Sqoop
> Issue Type: Sub-task
> Reporter: Veena Basavaraj
> Assignee: Veena Basavaraj
>
> I am not sure if the current api is extensible enough. It only supports
> upgrading the config info. Which actually can be now done via the rest api as
> well. So do we really need this config upgrade api was my first thought?
> I am also not sure how this code supports upgrades across different versions,
> since there seems to be no code in any of these that has knowledge of the
> repository version and what type of repository it really belongs to
> Split the api into
> ConnectorConfigUpgrader
> upgradeLinkConfig
> upgradeFromJobConfig
> upgradeToJobConfig
> DriverConfig Upgrader
> upgradeDriverConfig
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
