[ 
https://issues.apache.org/jira/browse/SQOOP-1551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14178415#comment-14178415
 ] 

Hudson commented on SQOOP-1551:
-------------------------------

FAILURE: Integrated in Sqoop2-hadoop100 #619 (See 
[https://builds.apache.org/job/Sqoop2-hadoop100/619/])
SQOOP-1551: Repository Upgrader api - Extensibility (jarcec: 
https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=39a22000079412d6181d43f40ae3cb20afc624c5)
* 
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConfigUpgrader.java
* 
core/src/main/java/org/apache/sqoop/driver/configuration/DriverConfiguration.java
* 
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnector.java
* core/src/test/java/org/apache/sqoop/driver/TestDriverConfigUpgrader.java
* common/src/main/java/org/apache/sqoop/model/MJob.java
* core/src/main/java/org/apache/sqoop/driver/DriverConfigUpgrader.java
* core/src/main/java/org/apache/sqoop/driver/JobManager.java
* core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java
* core/src/main/java/org/apache/sqoop/driver/Driver.java
* 
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConnectorUpgrader.java
* spi/src/main/java/org/apache/sqoop/connector/spi/SqoopConnector.java
* 
spi/src/main/java/org/apache/sqoop/connector/spi/ConnectorConfigurableUpgrader.java
* tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryLoadTool.java
* core/src/main/java/org/apache/sqoop/driver/DriverConfigValidator.java
* tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryDumpTool.java
* server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java
* 
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConnector.java
* core/src/main/java/org/apache/sqoop/connector/ConnectorHandler.java
* common/src/main/java/org/apache/sqoop/model/MConnector.java
* core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java
* common/src/main/java/org/apache/sqoop/model/MConfigurableType.java
* core/src/test/java/org/apache/sqoop/repository/TestJdbcRepository.java
* spi/src/main/java/org/apache/sqoop/configurable/ConfigurableUpgradeUtil.java
* 
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java
* common/src/main/java/org/apache/sqoop/model/MDriver.java
* spi/src/main/java/org/apache/sqoop/connector/spi/RepositoryUpgrader.java
* 
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnectorUpgrader.java
* core/src/main/java/org/apache/sqoop/connector/ConnectorManager.java
* spi/src/main/java/org/apache/sqoop/connector/ConfigurableError.java
* core/src/main/java/org/apache/sqoop/driver/configuration/JobConfiguration.java
* core/src/test/java/org/apache/sqoop/driver/TestJobManager.java
* core/src/main/java/org/apache/sqoop/driver/DriverUpgrader.java
* server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java
* server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java
* 
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestDriverHandling.java
* common/src/main/java/org/apache/sqoop/model/Configurable.java
* core/src/main/java/org/apache/sqoop/repository/Repository.java


> Repository Upgrader api - Extensibility
> ---------------------------------------
>
>                 Key: SQOOP-1551
>                 URL: https://issues.apache.org/jira/browse/SQOOP-1551
>             Project: Sqoop
>          Issue Type: Sub-task
>    Affects Versions: 1.99.4
>            Reporter: Veena Basavaraj
>            Assignee: Veena Basavaraj
>             Fix For: 1.99.4
>
>         Attachments: SQOOP-1551.patch, SQOOP-1551.patch, SQOOP-1551.patch, 
> SQOOP-1551.patch, SQOOP-1551.patch, SQOOP-1551.patch
>
>
> I am not sure if the current api is extensible enough. It only supports 
> upgrading the config info. Which actually can be now done via the rest api as 
> well. So do we really need this config upgrade api was my first thought?
> I am also not sure how this code supports upgrades across different versions, 
> since there seems to be no code in any of these that has knowledge of the 
> repository version and what type of repository it really belongs to
> Split the api into
> ConnectorConfigUpgrader
> upgradeLinkConfig
> upgradeFromJobConfig
> upgradeToJobConfig
> DriverConfig Upgrader
> upgradeDriverConfig



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to