> On Oct. 24, 2014, 1:55 p.m., Abraham Elmahrek wrote: > > With SQOOP-1589, I think things will be split up a bit. Should we wait for > > SQOOP-1589? > > Veena Basavaraj wrote: > I did see that change, all this does it makes it easy for some newbie to > see what is create and what is update and what is CRUD. I had a general > comment on 1589 after I took a look at it, queries are something we should > move out of the java code in the long run > > So postgres should start with it
Also one of the primary reason for splitting up this is to avoid a lot of merge conflicts amongst ourselves.! - Veena ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27137/#review58365 ----------------------------------------------------------- On Oct. 24, 2014, 7:32 a.m., Veena Basavaraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27137/ > ----------------------------------------------------------- > > (Updated Oct. 24, 2014, 7:32 a.m.) > > > Review request for Sqoop. > > > Repository: sqoop-sqoop2 > > > Description > ------- > > see jira for details. > > > Diffs > ----- > > > repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java > 633e9df > > repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaCreateQuery.java > PRE-CREATION > > repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaInsertUpdateDeleteSelectQuery.java > PRE-CREATION > > repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java > ce1830e > > repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaUpgradeQuery.java > PRE-CREATION > > repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java > b22dbd5 > > Diff: https://reviews.apache.org/r/27137/diff/ > > > Testing > ------- > > yes > > > Thanks, > > Veena Basavaraj > >
