> On Oct. 26, 2014, 4:41 a.m., Qian Xu wrote: > > repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java, > > line 20 > > <https://reviews.apache.org/r/27137/diff/2/?file=732162#file732162line20> > > > > Better expand imports (this may require to change IDE's optimize import > > settings)
I don't like the astersisk import either, but in this case it seems reasonable as those two files are very tighly connected. - Jarek ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27137/#review58553 ----------------------------------------------------------- On Oct. 27, 2014, 8:59 p.m., Veena Basavaraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27137/ > ----------------------------------------------------------- > > (Updated Oct. 27, 2014, 8:59 p.m.) > > > Review request for Sqoop. > > > Repository: sqoop-sqoop2 > > > Description > ------- > > see jira for details. > > > Diffs > ----- > > > repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java > b4b5f3e > > repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaCreateQuery.java > PRE-CREATION > > repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaInsertUpdateDeleteSelectQuery.java > PRE-CREATION > > repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java > 0a5b467 > > repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaUpgradeQuery.java > PRE-CREATION > > repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java > 528653c > > Diff: https://reviews.apache.org/r/27137/diff/ > > > Testing > ------- > > yes > > > Thanks, > > Veena Basavaraj > >
