----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27137/#review58553 -----------------------------------------------------------
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java <https://reviews.apache.org/r/27137/#comment99622> Better expand imports (this may require to change IDE's optimize import settings) repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java <https://reviews.apache.org/r/27137/#comment99623> Looks good, only one suggestion: better expand imports (Probably disable IDE's "optimize imports" settings) - Qian Xu On Oct. 24, 2014, 10:32 p.m., Veena Basavaraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27137/ > ----------------------------------------------------------- > > (Updated Oct. 24, 2014, 10:32 p.m.) > > > Review request for Sqoop. > > > Repository: sqoop-sqoop2 > > > Description > ------- > > see jira for details. > > > Diffs > ----- > > > repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java > 633e9df > > repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaCreateQuery.java > PRE-CREATION > > repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaInsertUpdateDeleteSelectQuery.java > PRE-CREATION > > repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java > ce1830e > > repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaUpgradeQuery.java > PRE-CREATION > > repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java > b22dbd5 > > Diff: https://reviews.apache.org/r/27137/diff/ > > > Testing > ------- > > yes > > > Thanks, > > Veena Basavaraj > >
