> On Oct. 25, 2014, 9:41 p.m., Qian Xu wrote: > > repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java, > > line 20 > > <https://reviews.apache.org/r/27137/diff/2/?file=732162#file732162line20> > > > > Looks good, only one suggestion: better expand imports (Probably > > disable IDE's "optimize imports" settings)
we should come up with a code convention for these, this was intentional to collapse it since every single of them is imported - Veena ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27137/#review58553 ----------------------------------------------------------- On Oct. 24, 2014, 7:32 a.m., Veena Basavaraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27137/ > ----------------------------------------------------------- > > (Updated Oct. 24, 2014, 7:32 a.m.) > > > Review request for Sqoop. > > > Repository: sqoop-sqoop2 > > > Description > ------- > > see jira for details. > > > Diffs > ----- > > > repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java > 633e9df > > repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaCreateQuery.java > PRE-CREATION > > repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaInsertUpdateDeleteSelectQuery.java > PRE-CREATION > > repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java > ce1830e > > repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaUpgradeQuery.java > PRE-CREATION > > repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java > b22dbd5 > > Diff: https://reviews.apache.org/r/27137/diff/ > > > Testing > ------- > > yes > > > Thanks, > > Veena Basavaraj > >
