----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27196/#review58504 -----------------------------------------------------------
common/pom.xml <https://reviews.apache.org/r/27196/#comment99583> We're currently using 2.0.0 on head of "sqoop2" branch, to iterate that it's our goal. What is the reason to change it to 1.99.4? common/src/main/java/org/apache/sqoop/common/VersionInfo.java <https://reviews.apache.org/r/27196/#comment99585> This will return the version of the code, it can be both on client or server, depending where the sqoop-common jar will be loaded. common/src/main/java/org/apache/sqoop/common/VersionInfo.java <https://reviews.apache.org/r/27196/#comment99584> Seems as unnecessary cosmetic change? shell/src/main/java/org/apache/sqoop/shell/core/Constants.java <https://reviews.apache.org/r/27196/#comment99587> I'm wondering why we are changing the order here? The order is intentionally bottom down, e.g. from most generic word to most concrete one, so that if you sort all properties you'll always get context (you can see all properties for given part of the code, ...) shell/src/main/java/org/apache/sqoop/shell/core/Constants.java <https://reviews.apache.org/r/27196/#comment99588> Is the plus between intentional? - Jarek Cecho On Oct. 25, 2014, 3:09 p.m., Veena Basavaraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27196/ > ----------------------------------------------------------- > > (Updated Oct. 25, 2014, 3:09 p.m.) > > > Review request for Sqoop and Jarek Cecho. > > > Repository: sqoop-sqoop2 > > > Description > ------- > > see JIRA for details > > > Diffs > ----- > > common/pom.xml 151a649 > common/src/main/java/org/apache/sqoop/common/VersionAnnotation.java acd901f > common/src/main/java/org/apache/sqoop/common/VersionInfo.java dcf522f > common/src/main/java/org/apache/sqoop/json/VersionBean.java 029a776 > common/src/test/java/org/apache/sqoop/common/TestVersionInfo.java 27d78f4 > > connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnector.java > 8469064 > > connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConnector.java > cce0e29 > server/src/main/java/org/apache/sqoop/handler/VersionRequestHandler.java > 64c4536 > shell/src/main/java/org/apache/sqoop/shell/ShowVersionFunction.java 4e7ad38 > shell/src/main/java/org/apache/sqoop/shell/core/Constants.java f2bbe7f > shell/src/main/resources/shell-resource.properties e2381dd > test/src/test/java/org/apache/sqoop/integration/server/VersionTest.java > beed82e > tools/src/main/java/org/apache/sqoop/tools/ToolRunner.java 769c2b4 > tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryDumpTool.java > 534877f > tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryLoadTool.java > 45c21a1 > > Diff: https://reviews.apache.org/r/27196/diff/ > > > Testing > ------- > > yet to be. > > > Thanks, > > Veena Basavaraj > >
