> On Oct. 25, 2014, 8:23 a.m., Jarek Cecho wrote: > > common/pom.xml, line 27 > > <https://reviews.apache.org/r/27196/diff/1/?file=733341#file733341line27> > > > > We're currently using 2.0.0 on head of "sqoop2" branch, to iterate that > > it's our goal. What is the reason to change it to 1.99.4?
>>this may not be the correct place to change this, but I am looking for >>answers. >>Ideally this should not be 2.0.0 until we really have a sqoop2 release. Can >>someone explain why we call it sqoop2 when we release as 1.99 versions? It is just confusing for a new bie to see 1.99.4 release version and docs and have 2.0.0 returned in here. > On Oct. 25, 2014, 8:23 a.m., Jarek Cecho wrote: > > common/src/main/java/org/apache/sqoop/common/VersionInfo.java, line 36 > > <https://reviews.apache.org/r/27196/diff/1/?file=733343#file733343line36> > > > > This will return the version of the code, it can be both on client or > > server, depending where the sqoop-common jar will be loaded. so does code version make it more apt? Just want the docs to be more clearer atleast. > On Oct. 25, 2014, 8:23 a.m., Jarek Cecho wrote: > > common/src/main/java/org/apache/sqoop/common/VersionInfo.java, line 37 > > <https://reviews.apache.org/r/27196/diff/1/?file=733343#file733343line37> > > > > Seems as unnecessary cosmetic change? sure. Some of it was just when I reading the code and utterly confused why we use 2.0.0 when we are not there yet. publicly if we were calling this 2.0.0 alpha it would be lot lot less confusing > On Oct. 25, 2014, 8:23 a.m., Jarek Cecho wrote: > > shell/src/main/java/org/apache/sqoop/shell/core/Constants.java, line 307 > > <https://reviews.apache.org/r/27196/diff/1/?file=733350#file733350line307> > > > > Is the plus between intentional? no, thanks for catching it. > On Oct. 25, 2014, 8:23 a.m., Jarek Cecho wrote: > > shell/src/main/java/org/apache/sqoop/shell/core/Constants.java, lines > > 296-301 > > <https://reviews.apache.org/r/27196/diff/1/?file=733350#file733350line296> > > > > I'm wondering why we are changing the order here? The order is > > intentionally bottom down, e.g. from most generic word to most concrete > > one, so that if you sort all properties you'll always get context (you can > > see all properties for given part of the code, ...) I have no idea what this ordering was there But reading it as common english, I would say client version rather than version client but this is not my biggest worry. :) I will change it back and say in one line of comment why it is named this way. ! - Veena ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27196/#review58504 ----------------------------------------------------------- On Oct. 25, 2014, 8:09 a.m., Veena Basavaraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27196/ > ----------------------------------------------------------- > > (Updated Oct. 25, 2014, 8:09 a.m.) > > > Review request for Sqoop and Jarek Cecho. > > > Repository: sqoop-sqoop2 > > > Description > ------- > > see JIRA for details > > > Diffs > ----- > > common/pom.xml 151a649 > common/src/main/java/org/apache/sqoop/common/VersionAnnotation.java acd901f > common/src/main/java/org/apache/sqoop/common/VersionInfo.java dcf522f > common/src/main/java/org/apache/sqoop/json/VersionBean.java 029a776 > common/src/test/java/org/apache/sqoop/common/TestVersionInfo.java 27d78f4 > > connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnector.java > 8469064 > > connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConnector.java > cce0e29 > server/src/main/java/org/apache/sqoop/handler/VersionRequestHandler.java > 64c4536 > shell/src/main/java/org/apache/sqoop/shell/ShowVersionFunction.java 4e7ad38 > shell/src/main/java/org/apache/sqoop/shell/core/Constants.java f2bbe7f > shell/src/main/resources/shell-resource.properties e2381dd > test/src/test/java/org/apache/sqoop/integration/server/VersionTest.java > beed82e > tools/src/main/java/org/apache/sqoop/tools/ToolRunner.java 769c2b4 > tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryDumpTool.java > 534877f > tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryLoadTool.java > 45c21a1 > > Diff: https://reviews.apache.org/r/27196/diff/ > > > Testing > ------- > > yet to be. > > > Thanks, > > Veena Basavaraj > >
