> On Oct. 25, 2014, 8:08 a.m., Veena Basavaraj wrote: > > connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnector.java, > > line 58 > > <https://reviews.apache.org/r/27196/diff/1/?file=733346#file733346line58> > > > > the sqoop connector says > > > > /** > > * Retrieve connector version. > > * > > * @return Version encoded as a string > > */ > > public abstract String getVersion(); > > > > > > But the implementation uses the sqoop server version. Is this correct? > > Veena Basavaraj wrote: > Jarce, can you answer this as well. thanks for a weekend review. > > Jarek Cecho wrote: > For the build-in components we're returning "Sqoop" version that is > generated during the build. It's not necessary a server version, it's just a > "release version". > > I think that built-in connectors should return the same version as rest > of the Sqoop as it's a user visible information and having different > versioning for some subcomponents would be really confusing. On the other > hand the current way doesn't seem to be entirely correct - the connector will > load the version information from sqoop-common jar. If I'll upgrade > sqoop-common and rest of Sqoop2, but from some reason I'll leave the old > connector jar around it will report different version then it should. This is > something that we should address in the future through a separate JIRA.
I have added a ticket for this. - Veena ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27196/#review58503 ----------------------------------------------------------- On Oct. 25, 2014, 9:09 a.m., Veena Basavaraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27196/ > ----------------------------------------------------------- > > (Updated Oct. 25, 2014, 9:09 a.m.) > > > Review request for Sqoop and Jarek Cecho. > > > Repository: sqoop-sqoop2 > > > Description > ------- > > see JIRA for details > > > Diffs > ----- > > common/src/main/java/org/apache/sqoop/common/VersionAnnotation.java acd901f > common/src/main/java/org/apache/sqoop/common/VersionInfo.java dcf522f > common/src/main/java/org/apache/sqoop/json/VersionBean.java 029a776 > common/src/test/java/org/apache/sqoop/common/TestVersionInfo.java 27d78f4 > > connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnector.java > 8469064 > > connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConnector.java > cce0e29 > server/src/main/java/org/apache/sqoop/handler/VersionRequestHandler.java > 64c4536 > shell/src/main/java/org/apache/sqoop/shell/ShowVersionFunction.java 4e7ad38 > shell/src/main/java/org/apache/sqoop/shell/core/Constants.java f2bbe7f > shell/src/main/resources/shell-resource.properties e2381dd > test/src/test/java/org/apache/sqoop/integration/server/VersionTest.java > beed82e > tools/src/main/java/org/apache/sqoop/tools/ToolRunner.java 769c2b4 > tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryDumpTool.java > 534877f > tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryLoadTool.java > 45c21a1 > > Diff: https://reviews.apache.org/r/27196/diff/ > > > Testing > ------- > > yet to be. > > > Thanks, > > Veena Basavaraj > >
