[ 
https://issues.apache.org/jira/browse/SQOOP-1168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14250153#comment-14250153
 ] 

Veena Basavaraj commented on SQOOP-1168:
----------------------------------------

[~abec]

>>> Incremental Reading - is this not covered in Extractor.getRowsRead()?
That is an implementation detail. Of course the Extractor  extract method is 
where the reading will happen.be it full scan or incremental or delta or 
watever that connector calls it. I am not sure why you mention getRowsRead() , 
it will return the delta records read, or the full list of records read, That 
should not change

>>> Incremental Writing - Is this similar to Extractor.getRowsRead() (Except 
>>> getRowsWritten)?
Writing happens in the Loader. May it was a typo that you did by saying 
Extractor...Again an implementation detail, I would assume it would happen in 
Loader, but as complicated as the writing can be, with merges ( and supporting 
overwrites, we need to support a better way to do this ) See SQOOP-1602 for 
more discussions on this.  [~vinothchandar] has very good thoughts on that

>>>>>Annotations or methods work. Let's try to stabilize the APIs in 1.99.5. If 
>>>>>we choose annotations, create a Jira for getSupportedDirections to change 
>>>>>to annotations and assign it to me (Abraham Elmahrek).

Sure, there is already a broader ticket that has been laying around unresolved, 
it is on the 1.99.5 roadmap https://issues.apache.org/jira/browse/SQOOP-1644. 
We need to discuss that in more details before we jump into implementations

>>> I don't understand fully what IncrementalConfig is or where it lives. In 
>>> the example: "SELECT * from table where id > = 24", which part is defined 
>>> in the IncrementalConfig?

See the comment above that explains what configs mean and that we dont want to 
introduce another term called "Predicate", If you read the comments below, it 
also says why I dont want a new term to add to confusion, when configs can 
solve it

> Sqoop2: Delta Fetch/ Merge ( formerly called Incremental Import )
> -----------------------------------------------------------------
>
>                 Key: SQOOP-1168
>                 URL: https://issues.apache.org/jira/browse/SQOOP-1168
>             Project: Sqoop
>          Issue Type: Bug
>            Reporter: Hari Shreedharan
>            Assignee: Veena Basavaraj
>             Fix For: 1.99.5
>
>
> The formal design wiki is here 
> https://cwiki.apache.org/confluence/display/SQOOP/Delta+Fetch+and+Merge+Design



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to