> On Jan. 13, 2015, 11:47 p.m., Veena Basavaraj wrote: > > Another place the comment needs to be modfied > > > > /** > > * > > * @param fields > > * @return Return the data in "fields" converted from matching the > > fromSchema to matching the toSchema. > > * Right not "converted" means re-ordering if needed and handling nulls. > > */ > > abstract public Object[] getMatchingData(Object[] fields); > > > > > > Please search all places in code, I am surprised there are so many places > > and I keep missing it
I removed the line is because the file is currently modified and IntelliJ warns the corrupt docstring. I cannot find any other similar issue in modified files. If you think the do-me-a-favor change is not relevant to the patch, I can revert it. We have discussed some kind of things before. A static style check tool in maven will help. Please feel free to create a ticket. - Qian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29849/#review67863 ----------------------------------------------------------- On Jan. 13, 2015, 11:14 p.m., Qian Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29849/ > ----------------------------------------------------------- > > (Updated Jan. 13, 2015, 11:14 p.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-1988 > https://issues.apache.org/jira/browse/SQOOP-1988 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > see jira > > > Diffs > ----- > > > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/matcher/LocationMatcher.java > d92723e > > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/matcher/Matcher.java > 36ac5a5 > > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/matcher/NameMatcher.java > 7cbc39f > > connector/connector-sdk/src/test/java/org/apache/sqoop/connector/matcher/TestLocationMatcher.java > 624fa7b > > connector/connector-sdk/src/test/java/org/apache/sqoop/connector/matcher/TestNameMatcher.java > 76ff0da > > Diff: https://reviews.apache.org/r/29849/diff/ > > > Testing > ------- > > Existing tests passed > > > Thanks, > > Qian Xu > >
