> On 三月 5, 2015, 5:59 a.m., Colin Ma wrote: > > sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAuthorizationHander.java, > > line 57 > > <https://reviews.apache.org/r/31657/diff/1/?file=882549#file882549line57> > > > > The actual AccessController should be configured in conf file.
Thanks colin for your advice. I will fix it > On 三月 5, 2015, 5:59 a.m., Colin Ma wrote: > > sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/NoopSentryAccessController.java, > > line 32 > > <https://reviews.apache.org/r/31657/diff/1/?file=882547#file882547line32> > > > > When using policy file, the result of following methods are not correct: > > getAllRoles > > getPrincipalsByRole > > getRolesByPrincipal If sqoop useing policy file as backend, these commands make no sense. > On 三月 5, 2015, 5:59 a.m., Colin Ma wrote: > > sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/binding/SqoopAuthBinding.java, > > line 137 > > <https://reviews.apache.org/r/31657/diff/1/?file=882551#file882551line137> > > > > The method is not necessary. Yeah, I will fix it. Thanks for your comment - shen ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31657/#review75297 ----------------------------------------------------------- On 三月 5, 2015, 2:36 a.m., shen guoquan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31657/ > ----------------------------------------------------------- > > (Updated 三月 5, 2015, 2:36 a.m.) > > > Review request for sentry, Sqoop, Abraham Elmahrek, Xiaomeng Huang, Colin Ma, > Dapeng Sun, and Prasad Mujumdar. > > > Repository: sentry > > > Description > ------- > > Sentry Sqoop binding framework for role-based authorization > > > Diffs > ----- > > pom.xml 4c80916 > sentry-binding/pom.xml 7428aa5 > sentry-binding/sentry-binding-sqoop/pom.xml PRE-CREATION > > sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/PrincipalDesc.java > PRE-CREATION > > sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/SentrySqoopError.java > PRE-CREATION > > sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/NoopSentryAccessController.java > PRE-CREATION > > sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAccessController.java > PRE-CREATION > > sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAuthorizationHander.java > PRE-CREATION > > sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAuthorizationValidator.java > PRE-CREATION > > sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/binding/SqoopAuthBinding.java > PRE-CREATION > > sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/conf/SqoopAuthConf.java > PRE-CREATION > > sentry-binding/sentry-binding-sqoop/src/test/java/org/apache/sentry/sqoop/TestSqoopAuthConf.java > PRE-CREATION > > sentry-binding/sentry-binding-sqoop/src/test/resources/sentry-all-configure-site.xml > PRE-CREATION > > sentry-binding/sentry-binding-sqoop/src/test/resources/sentry-no-configure-site.xml > PRE-CREATION > sentry-dist/pom.xml f63b33b > > sentry-provider/sentry-provider-common/src/main/java/org/apache/sentry/provider/common/AuthorizationComponent.java > def3486 > > Diff: https://reviews.apache.org/r/31657/diff/ > > > Testing > ------- > > Ran unit tests > > > Thanks, > > shen guoquan > >
