> On 三月 28, 2015, 12:30 a.m., Abraham Elmahrek wrote: > > I do have one high level comment about Sqoop integration. Sqoop-core is not > > intended to be depended on. So perhaps we can file a Jira with the Sqoop > > community to fix?
Hi abe. Thanks for your review and comment. I think the sentry was integrated into the sqoop server. The sqoop client will not require the sentry library. The sentry will need to depend on the sqoop-core package. It will need to use the AuthorizationHandler and AuthenticationHandler these classes. If it does not allow to depend on the core package. May be it will be a little difficult to integration. Thanks. I am looking forward to your comments. > On 三月 28, 2015, 12:30 a.m., Abraham Elmahrek wrote: > > sentry-binding/sentry-binding-sqoop/pom.xml, line 72 > > <https://reviews.apache.org/r/31657/diff/4/?file=906563#file906563line72> > > > > Should not depend on sqoop-core. > > Abraham Elmahrek wrote: > heads up... we're having some discussions in Sqoop about this. Thanks for your comment. I will fix it. But The sentry will depend on the sqoop-server package. The sqoop-server is depend on the sqoop-core. So the sentry is indirectly depend on the sqoop-core. - shen ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31657/#review78133 ----------------------------------------------------------- On 三月 26, 2015, 8:54 a.m., shen guoquan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31657/ > ----------------------------------------------------------- > > (Updated 三月 26, 2015, 8:54 a.m.) > > > Review request for sentry, Sqoop, Abraham Elmahrek, Xiaomeng Huang, Colin Ma, > Dapeng Sun, and Prasad Mujumdar. > > > Repository: sentry > > > Description > ------- > > Sentry Sqoop binding framework for role-based authorization > > > Diffs > ----- > > pom.xml 2f97880 > sentry-binding/pom.xml 7428aa5 > sentry-binding/sentry-binding-sqoop/pom.xml PRE-CREATION > > sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/PrincipalDesc.java > PRE-CREATION > > sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/SentrySqoopError.java > PRE-CREATION > > sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/NoopSentryAccessController.java > PRE-CREATION > > sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAccessController.java > PRE-CREATION > > sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAuthorizationHander.java > PRE-CREATION > > sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAuthorizationValidator.java > PRE-CREATION > > sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/binding/SqoopAuthBinding.java > PRE-CREATION > > sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/conf/SqoopAuthConf.java > PRE-CREATION > > sentry-binding/sentry-binding-sqoop/src/test/java/org/apache/sentry/sqoop/MockAuthenticationProvider.java > PRE-CREATION > > sentry-binding/sentry-binding-sqoop/src/test/java/org/apache/sentry/sqoop/TestSentryAuthorizationHander.java > PRE-CREATION > > sentry-binding/sentry-binding-sqoop/src/test/java/org/apache/sentry/sqoop/TestSqoopAuthConf.java > PRE-CREATION > > sentry-binding/sentry-binding-sqoop/src/test/resources/no-configure-sentry-site.xml > PRE-CREATION > sentry-binding/sentry-binding-sqoop/src/test/resources/sentry-site.xml > PRE-CREATION > > sentry-binding/sentry-binding-sqoop/src/test/resources/test-authz-provider.ini > PRE-CREATION > sentry-dist/pom.xml f7a663b > > sentry-provider/sentry-provider-common/src/main/java/org/apache/sentry/provider/common/AuthorizationComponent.java > def3486 > > Diff: https://reviews.apache.org/r/31657/diff/ > > > Testing > ------- > > Ran unit tests > > > Thanks, > > shen guoquan > >
