----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31657/#review78140 -----------------------------------------------------------
And a quick follow up... sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAuthorizationHander.java <https://reviews.apache.org/r/31657/#comment126624> It seems a lot of this was done in DefaultAuthorizationHandler in Sqoop2. Maybe you can just extend it or re-use it completely? sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAuthorizationHander.java <https://reviews.apache.org/r/31657/#comment126622> Why not just re-use SecurityFactory in sqoop? Maybe this is for testing? Seems like a weird usability thing to use a different configuration in Sqoop2. - Abraham Elmahrek On March 26, 2015, 8:54 a.m., shen guoquan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31657/ > ----------------------------------------------------------- > > (Updated March 26, 2015, 8:54 a.m.) > > > Review request for sentry, Sqoop, Abraham Elmahrek, Xiaomeng Huang, Colin Ma, > Dapeng Sun, and Prasad Mujumdar. > > > Repository: sentry > > > Description > ------- > > Sentry Sqoop binding framework for role-based authorization > > > Diffs > ----- > > pom.xml 2f97880 > sentry-binding/pom.xml 7428aa5 > sentry-binding/sentry-binding-sqoop/pom.xml PRE-CREATION > > sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/PrincipalDesc.java > PRE-CREATION > > sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/SentrySqoopError.java > PRE-CREATION > > sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/NoopSentryAccessController.java > PRE-CREATION > > sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAccessController.java > PRE-CREATION > > sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAuthorizationHander.java > PRE-CREATION > > sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAuthorizationValidator.java > PRE-CREATION > > sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/binding/SqoopAuthBinding.java > PRE-CREATION > > sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/conf/SqoopAuthConf.java > PRE-CREATION > > sentry-binding/sentry-binding-sqoop/src/test/java/org/apache/sentry/sqoop/MockAuthenticationProvider.java > PRE-CREATION > > sentry-binding/sentry-binding-sqoop/src/test/java/org/apache/sentry/sqoop/TestSentryAuthorizationHander.java > PRE-CREATION > > sentry-binding/sentry-binding-sqoop/src/test/java/org/apache/sentry/sqoop/TestSqoopAuthConf.java > PRE-CREATION > > sentry-binding/sentry-binding-sqoop/src/test/resources/no-configure-sentry-site.xml > PRE-CREATION > sentry-binding/sentry-binding-sqoop/src/test/resources/sentry-site.xml > PRE-CREATION > > sentry-binding/sentry-binding-sqoop/src/test/resources/test-authz-provider.ini > PRE-CREATION > sentry-dist/pom.xml f7a663b > > sentry-provider/sentry-provider-common/src/main/java/org/apache/sentry/provider/common/AuthorizationComponent.java > def3486 > > Diff: https://reviews.apache.org/r/31657/diff/ > > > Testing > ------- > > Ran unit tests > > > Thanks, > > shen guoquan > >
