> On 三月 21, 2015, 2:16 a.m., Prasad Mujumdar wrote: > > sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAuthorizationHander.java, > > line 57 > > <https://reviews.apache.org/r/31657/diff/3/?file=898554#file898554line57> > > > > Does this need to be info ? I am not sure how often sqoop calls this. > > It might be too much noise in the log file.
Thanks for your advice. I will fix it > On 三月 21, 2015, 2:16 a.m., Prasad Mujumdar wrote: > > sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAuthorizationHander.java, > > line 66 > > <https://reviews.apache.org/r/31657/diff/3/?file=898554#file898554line66> > > > > Should this be InstantiationException ? Good suggestion. I will change > On 三月 21, 2015, 2:16 a.m., Prasad Mujumdar wrote: > > sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAuthorizationHander.java, > > line 92 > > <https://reviews.apache.org/r/31657/diff/3/?file=898554#file898554line92> > > > > It would be great if SqoopConfig could directly indentify if strong > > authorization is enabled rather than Sentry figuring out that from sqoop > > config. > > Let's work with Sqoop comminuty to make this into an API in future. I agree with you. I will told richard to response this situation. > On 三月 21, 2015, 2:16 a.m., Prasad Mujumdar wrote: > > sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAuthorizationValidator.java, > > line 60 > > <https://reviews.apache.org/r/31657/diff/3/?file=898555#file898555line60> > > > > " does not have privilege for action " ? I will fix it. > On 三月 21, 2015, 2:16 a.m., Prasad Mujumdar wrote: > > sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/binding/SqoopAuthBinding.java, > > line 351 > > <https://reviews.apache.org/r/31657/diff/3/?file=898556#file898556line351> > > > > Nit: formatting. Thanks for your reminder. > On 三月 21, 2015, 2:16 a.m., Prasad Mujumdar wrote: > > sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/binding/SqoopAuthBinding.java, > > line 382 > > <https://reviews.apache.org/r/31657/diff/3/?file=898556#file898556line382> > > > > Is there a reason we don't pass the full exception to SqoopException() ? I will put the full exception to SqoopException. Thanks for your suggestion - shen ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31657/#review77299 ----------------------------------------------------------- On 三月 18, 2015, 2:14 a.m., shen guoquan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31657/ > ----------------------------------------------------------- > > (Updated 三月 18, 2015, 2:14 a.m.) > > > Review request for sentry, Sqoop, Abraham Elmahrek, Xiaomeng Huang, Colin Ma, > Dapeng Sun, and Prasad Mujumdar. > > > Repository: sentry > > > Description > ------- > > Sentry Sqoop binding framework for role-based authorization > > > Diffs > ----- > > pom.xml 4c80916 > sentry-binding/pom.xml 7428aa5 > sentry-binding/sentry-binding-sqoop/pom.xml PRE-CREATION > > sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/PrincipalDesc.java > PRE-CREATION > > sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/SentrySqoopError.java > PRE-CREATION > > sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/NoopSentryAccessController.java > PRE-CREATION > > sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAccessController.java > PRE-CREATION > > sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAuthorizationHander.java > PRE-CREATION > > sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAuthorizationValidator.java > PRE-CREATION > > sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/binding/SqoopAuthBinding.java > PRE-CREATION > > sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/conf/SqoopAuthConf.java > PRE-CREATION > > sentry-binding/sentry-binding-sqoop/src/test/java/org/apache/sentry/sqoop/MockAuthenticationProvider.java > PRE-CREATION > > sentry-binding/sentry-binding-sqoop/src/test/java/org/apache/sentry/sqoop/TestSentryAuthorizationHander.java > PRE-CREATION > > sentry-binding/sentry-binding-sqoop/src/test/java/org/apache/sentry/sqoop/TestSqoopAuthConf.java > PRE-CREATION > > sentry-binding/sentry-binding-sqoop/src/test/resources/no-configure-sentry-site.xml > PRE-CREATION > sentry-binding/sentry-binding-sqoop/src/test/resources/sentry-site.xml > PRE-CREATION > > sentry-binding/sentry-binding-sqoop/src/test/resources/test-authz-provider.ini > PRE-CREATION > sentry-dist/pom.xml f63b33b > > sentry-provider/sentry-provider-common/src/main/java/org/apache/sentry/provider/common/AuthorizationComponent.java > def3486 > > Diff: https://reviews.apache.org/r/31657/diff/ > > > Testing > ------- > > Ran unit tests > > > Thanks, > > shen guoquan > >
