Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/294#discussion_r22228158
--- Diff: storm-core/src/clj/backtype/storm/ui/core.clj ---
@@ -52,15 +52,9 @@
(map #(.get_stats ^ExecutorSummary %))
(filter not-nil?)))
-(defn read-storm-version
+(def read-storm-version
"Returns a string containing the Storm version or 'Unknown'."
- []
- (let [storm-home (System/getProperty "storm.home")
- release-path (format "%s/RELEASE" storm-home)
- release-file (File. release-path)]
- (if (and (.exists release-file) (.isFile release-file))
- (trim (slurp release-path))
- "Unknown")))
+ (str VersionInfo/getVersion))
--- End diff --
This is not valid clojure. It should probably be something like
```(str (VersionInfo/getVersion))```
you are also going to have to explicitly import VersionInfo info core.clj.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
