Github user revans2 commented on a diff in the pull request:

    https://github.com/apache/storm/pull/294#discussion_r22720414
  
    --- Diff: storm-core/src/jvm/backtype/storm/package-info.java ---
    @@ -0,0 +1,7 @@
    +/*
    --- End diff --
    
    This file is also a build artifact and shouldn't be checked in.  Please add 
it to the .gitignore file.  I would prefer to have it placed in a different 
directory from the rest of the source code.  The maven plugin 
org.codehaus.mojo:build-helper-maven-plugin is a good way to add in a generated 
source directory using the add-source goal.  It also allows us to not include a 
checksum of this generated file in the checksum of the source.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to