Github user revans2 commented on a diff in the pull request:

    https://github.com/apache/storm/pull/294#discussion_r22228250
  
    --- Diff: storm-core/src/saveVersion.sh ---
    @@ -0,0 +1,42 @@
    +s file is used to generate the package-info.java class that
    +# records the version, revision, branch, user, timestamp, and url
    +unset LANG
    +unset LC_CTYPE
    +unset LC_TIME
    +version=$1
    +build_dir=$2
    +user=`whoami`
    +date=`date`
    +cwd=`pwd`
    +if [ -d .git ]; then
    --- End diff --
    
    This does not work with how the code is run from maven.  The working 
directory, at least for me, seems to be storm-core, so it never finds .git and 
is not able to detect that the code is in git.  subversion should not have the 
same issues.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to