Github user revans2 commented on a diff in the pull request:

    https://github.com/apache/storm/pull/294#discussion_r22228357
  
    --- Diff: storm-dist/binary/src/main/assembly/binary.xml ---
    @@ -131,13 +131,6 @@
             </file>
             <!-- TODO this should be a generated file from "target" -->
             <file>
    -            <source>${project.basedir}/../../VERSION</source>
    -            <outputDirectory>/</outputDirectory>
    -            <destName>RELEASE</destName>
    --- End diff --
    
    There are explicit checks elsewhere in the code looking for the RELEASE 
file.  If it is not present some parts of the code assume they are not part of 
a valid release.
    
    https://github.com/caofangkun/apache-storm/blob/storm-243/bin/storm#L86-91
    
    is one example of where this happens.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to