[ 
https://issues.apache.org/jira/browse/STORM-690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14337557#comment-14337557
 ] 

Jungtaek Lim commented on STORM-690:
------------------------------------

Since Jedis implements Closeable, We can use Jedis.close() instead of calling 
JedisPool.returnResource() or JedisPool.returnBrokenResource().

> [storm-redis] Broken Jedis Connection should be returned as broken 
> -------------------------------------------------------------------
>
>                 Key: STORM-690
>                 URL: https://issues.apache.org/jira/browse/STORM-690
>             Project: Apache Storm
>          Issue Type: Bug
>    Affects Versions: 0.10.0
>            Reporter: Jungtaek Lim
>            Assignee: Jungtaek Lim
>
> While using JedisPool, any broken Jedis instances should be returned as 
> broken.
> (Thanks to Apache Commons Pool 2, we can delegate verifying instances to 
> JedisPool itself by configuration, but performance will be decreased a bit.)
> We can try-with-finally with Jedis / JedisCluster instance, but Storm should 
> be run at least JDK 6 so we can't apply it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to