[
https://issues.apache.org/jira/browse/STORM-690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14337596#comment-14337596
]
ASF GitHub Bot commented on STORM-690:
--------------------------------------
Github user wfeng1982 commented on the pull request:
https://github.com/apache/storm/pull/444#issuecomment-76101773
发自网易邮箱大师
在2015年02月26日 08:45,Jungtaek Lim 写道:
See https://issues.apache.org/jira/browse/STORM-690 for more details.
You can view, comment on, or merge this pull request online at:
https://github.com/apache/storm/pull/444
Commit Summary
Return Jedis into JedisPool with marking 'broken' if connection is broken
File Changes
Mexternal/storm-redis/src/main/java/org/apache/storm/redis/trident/state/RedisState.java
(2)
Patch Links:
https://github.com/apache/storm/pull/444.patch
https://github.com/apache/storm/pull/444.diff
—
Reply to this email directly or view it on GitHub.
> [storm-redis] Broken Jedis Connection should be returned as broken
> -------------------------------------------------------------------
>
> Key: STORM-690
> URL: https://issues.apache.org/jira/browse/STORM-690
> Project: Apache Storm
> Issue Type: Bug
> Affects Versions: 0.10.0
> Reporter: Jungtaek Lim
> Assignee: Jungtaek Lim
>
> While using JedisPool, any broken Jedis instances should be returned as
> broken.
> (Thanks to Apache Commons Pool 2, we can delegate verifying instances to
> JedisPool itself by configuration, but performance will be decreased a bit.)
> We can try-with-finally with Jedis / JedisCluster instance, but Storm should
> be run at least JDK 6 so we can't apply it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)