[
https://issues.apache.org/jira/browse/STORM-690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14357563#comment-14357563
]
ASF GitHub Bot commented on STORM-690:
--------------------------------------
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/444#issuecomment-78366813
The change looks fine to me +1.
> [storm-redis] Broken Jedis Connection should be returned as broken
> -------------------------------------------------------------------
>
> Key: STORM-690
> URL: https://issues.apache.org/jira/browse/STORM-690
> Project: Apache Storm
> Issue Type: Bug
> Affects Versions: 0.10.0
> Reporter: Jungtaek Lim
> Assignee: Jungtaek Lim
>
> While using JedisPool, any broken Jedis instances should be returned as
> broken.
> (Thanks to Apache Commons Pool 2, we can delegate verifying instances to
> JedisPool itself by configuration, but performance will be decreased a bit.)
> We can try-with-finally with Jedis / JedisCluster instance, but Storm should
> be run at least JDK 6 so we can't apply it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
