[
https://issues.apache.org/jira/browse/STORM-690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14337586#comment-14337586
]
ASF GitHub Bot commented on STORM-690:
--------------------------------------
GitHub user HeartSaVioR opened a pull request:
https://github.com/apache/storm/pull/444
STORM-690 Return Jedis into JedisPool with marking 'broken' if connection
is broken
See https://issues.apache.org/jira/browse/STORM-690 for more details.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/HeartSaVioR/storm STORM-690
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/444.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #444
----
commit 6b6eda7a4b459448bd26e605674a8df973febb97
Author: Jungtaek Lim <[email protected]>
Date: 2015-02-26T00:43:52Z
Return Jedis into JedisPool with marking 'broken' if connection is broken
----
> [storm-redis] Broken Jedis Connection should be returned as broken
> -------------------------------------------------------------------
>
> Key: STORM-690
> URL: https://issues.apache.org/jira/browse/STORM-690
> Project: Apache Storm
> Issue Type: Bug
> Affects Versions: 0.10.0
> Reporter: Jungtaek Lim
> Assignee: Jungtaek Lim
>
> While using JedisPool, any broken Jedis instances should be returned as
> broken.
> (Thanks to Apache Commons Pool 2, we can delegate verifying instances to
> JedisPool itself by configuration, but performance will be decreased a bit.)
> We can try-with-finally with Jedis / JedisCluster instance, but Storm should
> be run at least JDK 6 so we can't apply it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)