[ 
https://issues.apache.org/jira/browse/STORM-1057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14938793#comment-14938793
 ] 

ASF GitHub Bot commented on STORM-1057:
---------------------------------------

Github user revans2 commented on a diff in the pull request:

    https://github.com/apache/storm/pull/753#discussion_r40846010
  
    --- Diff: storm-core/src/storm.thrift ---
    @@ -204,6 +203,7 @@ struct ExecutorStats {
       2: required map<string, map<string, i64>> transferred;
       3: required ExecutorSpecificStats specific;
       4: required double rate;
    +  5: required map<string, map<string, double>> throughput;
    --- End diff --
    
    If we want to be able to add this as a rolling upgrade this needs to be 
optional, and we need the code everywhere to be able to handle when it is not 
provided.
    
    To me this feature is not important enough to force downtime in a cluster.


> Add throughput metric to spout/bolt and display them on web ui
> --------------------------------------------------------------
>
>                 Key: STORM-1057
>                 URL: https://issues.apache.org/jira/browse/STORM-1057
>             Project: Apache Storm
>          Issue Type: New Feature
>          Components: storm-core
>            Reporter: Li Wang
>            Assignee: Li Wang
>   Original Estimate: 168h
>  Remaining Estimate: 168h
>
> Throughput is a fundamental metric to reasoning about the performance 
> bottleneck of a topology. Displaying the throughputs of components and tasks 
> on the web ui could greatly facilitate the user identifying the performance 
> bottleneck and checking whether the the workload among components and tasks 
> are balanced. 
> What to do:
> 1. Measure the throughput of each spout/bolt.
> 2. Display the throughput metrics on web UI.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to