[
https://issues.apache.org/jira/browse/STORM-1057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14938833#comment-14938833
]
ASF GitHub Bot commented on STORM-1057:
---------------------------------------
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/753#discussion_r40849246
--- Diff: storm-core/src/clj/backtype/storm/daemon/executor.clj ---
@@ -570,7 +575,11 @@
(tasks-fn
out-stream-id values))
rooted? (and message-id
has-ackers?)
root-id (if rooted?
(MessageId/generateId rand))
- out-ids (fast-list-for [t
out-tasks] (if rooted? (MessageId/generateId rand)))]
+ out-ids (fast-list-for [t
out-tasks] (if rooted? (MessageId/generateId rand)))
+ sampler? (sampler)]
+ (when sampler?
+ (.notify rate-tracker (count
out-tasks))
+ (stats/update-stats-throughput!
(:stats executor-data) out-stream-id (.reportRate rate-tracker)))
--- End diff --
This is calculating the rate for the spout ignoring the stream-id, and then
storing it into the other stats saying it is for a specific stream id. That
does not work. Either we have to drop the stream-id from the reported stats or
we have to calculate it correctly per stream id.
> Add throughput metric to spout/bolt and display them on web ui
> --------------------------------------------------------------
>
> Key: STORM-1057
> URL: https://issues.apache.org/jira/browse/STORM-1057
> Project: Apache Storm
> Issue Type: New Feature
> Components: storm-core
> Reporter: Li Wang
> Assignee: Li Wang
> Original Estimate: 168h
> Remaining Estimate: 168h
>
> Throughput is a fundamental metric to reasoning about the performance
> bottleneck of a topology. Displaying the throughputs of components and tasks
> on the web ui could greatly facilitate the user identifying the performance
> bottleneck and checking whether the the workload among components and tasks
> are balanced.
> What to do:
> 1. Measure the throughput of each spout/bolt.
> 2. Display the throughput metrics on web UI.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
