[
https://issues.apache.org/jira/browse/STORM-1057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14938823#comment-14938823
]
ASF GitHub Bot commented on STORM-1057:
---------------------------------------
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/753#discussion_r40848297
--- Diff: storm-core/src/clj/backtype/storm/stats.clj ---
@@ -218,11 +220,17 @@
[stats stream amt]
(update-executor-stat! stats [:common :transferred] stream (*
(stats-rate stats) amt)))
+(defn update-stats-throughput! [stats stream throughput]
+ (update-executor-stat! stats [:common :throughput] stream (* (stats-rate
stats) throughput)))
+
(defn bolt-execute-tuple!
- [^BoltExecutorStats stats component stream latency-ms]
+ [^BoltExecutorStats stats component stream throughput latency-ms]
(let [key [component stream]]
(update-executor-stat! stats :executed key (stats-rate stats))
- (update-executor-stat! stats :execute-latencies key latency-ms)))
+ (update-executor-stat! stats :execute-latencies key latency-ms)
+ (update-stats-throughput! stats stream throughput)
+ ))
+
--- End diff --
Extra blank line here.
> Add throughput metric to spout/bolt and display them on web ui
> --------------------------------------------------------------
>
> Key: STORM-1057
> URL: https://issues.apache.org/jira/browse/STORM-1057
> Project: Apache Storm
> Issue Type: New Feature
> Components: storm-core
> Reporter: Li Wang
> Assignee: Li Wang
> Original Estimate: 168h
> Remaining Estimate: 168h
>
> Throughput is a fundamental metric to reasoning about the performance
> bottleneck of a topology. Displaying the throughputs of components and tasks
> on the web ui could greatly facilitate the user identifying the performance
> bottleneck and checking whether the the workload among components and tasks
> are balanced.
> What to do:
> 1. Measure the throughput of each spout/bolt.
> 2. Display the throughput metrics on web UI.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
