[
https://issues.apache.org/jira/browse/STORM-1057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14938807#comment-14938807
]
ASF GitHub Bot commented on STORM-1057:
---------------------------------------
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/753#discussion_r40847090
--- Diff: storm-core/src/jvm/backtype/storm/utils/RateTracker.java ---
@@ -72,7 +80,7 @@ public RateTracker(int validTimeWindowInMils, int
numOfSlides, boolean simulate
* @param count number of arrivals
*/
public void notify(long count) {
- _histograms[_histograms.length-1]+=count;
+ _histograms[_numOfSlides - 1] += count;
--- End diff --
I don't think this is thread safe. I'm not sure that is a big deal for
this code, as I am not aware of any spouts that emit from multiple threads
ignoring the call to nextTuple. But we should file a JIRA at least to fix it
because the disruptor code calls it from multiple threads, and the counts will
get off.
> Add throughput metric to spout/bolt and display them on web ui
> --------------------------------------------------------------
>
> Key: STORM-1057
> URL: https://issues.apache.org/jira/browse/STORM-1057
> Project: Apache Storm
> Issue Type: New Feature
> Components: storm-core
> Reporter: Li Wang
> Assignee: Li Wang
> Original Estimate: 168h
> Remaining Estimate: 168h
>
> Throughput is a fundamental metric to reasoning about the performance
> bottleneck of a topology. Displaying the throughputs of components and tasks
> on the web ui could greatly facilitate the user identifying the performance
> bottleneck and checking whether the the workload among components and tasks
> are balanced.
> What to do:
> 1. Measure the throughput of each spout/bolt.
> 2. Display the throughput metrics on web UI.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
