Github user d2r commented on a diff in the pull request:

    https://github.com/apache/storm/pull/845#discussion_r45241070
  
    --- Diff: storm-core/src/clj/backtype/storm/daemon/supervisor.clj ---
    @@ -238,20 +241,21 @@
     (defn- rmr-as-user
       "Launches a process owned by the given user that deletes the given path
       recursively.  Throws RuntimeException if the directory is not removed."
    -  [conf id user path]
    +  [conf id path]
    +  (let [user (Utils/getFileOwner path)]
       (worker-launcher-and-wait conf
                                 user
                                 ["rmr" path]
                                 :log-prefix (str "rmr " id))
       (if (exists-file? path)
    -    (throw (RuntimeException. (str path " was not deleted")))))
    +    (throw (RuntimeException. (str path " was not deleted"))))))
    --- End diff --
    
    Need to indent since we are adding the `let`.  Removing the `user` param 
was a good change here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to