Github user d2r commented on a diff in the pull request:

    https://github.com/apache/storm/pull/845#discussion_r45261961
  
    --- Diff: storm-core/src/clj/backtype/storm/daemon/supervisor.clj ---
    @@ -476,14 +539,21 @@
                                                (:sync-retry supervisor))
               new-assignment (->> all-assignment
                                   (filter-key #(.confirmAssigned isupervisor 
%)))
    -          assigned-storm-ids (assigned-storm-ids-from-port-assignments 
new-assignment)]
    +          rm-blob-refs? true
    --- End diff --
    
    This isn't a predicate (function that returns a boolean), it's just a var 
holding `true`.  We only use it in one spot, so maybe we should remove this 
binding and pass `true` below?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to