Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/845#discussion_r45262228
--- Diff: storm-core/src/clj/backtype/storm/daemon/supervisor.clj ---
@@ -510,22 +582,54 @@
;; synchronize-supervisor doesn't try to launch workers for which the
;; resources don't exist
(if on-windows? (shutdown-disallowed-workers supervisor))
- (doseq [storm-id downloaded-storm-ids]
+ (doseq [storm-id all-downloaded-storm-ids]
(when-not (storm-code-map storm-id)
(log-message "Removing code for storm id "
storm-id)
- (try
- (rmr (supervisor-stormdist-root conf storm-id))
- (catch Exception e (log-message (.getMessage e))))
- ))
- (.add processes-event-manager sync-processes)
- )))
+ (rm-topo-files conf storm-id localizer rm-blob-refs?)))
+ (.add processes-event-manager sync-processes))))
(defn mk-supervisor-capacities
[conf]
{Config/SUPERVISOR_MEMORY_CAPACITY_MB (double (conf
SUPERVISOR-MEMORY-CAPACITY-MB))
Config/SUPERVISOR_CPU_CAPACITY (double (conf SUPERVISOR-CPU-CAPACITY))})
+(defn update-blobs-for-topology!
+ "Update each blob listed in the topology configuration if the latest
version of the blob
+ has not been downloaded."
+ [conf storm-id localizer]
+ (let [storm-conf (read-supervisor-storm-conf conf storm-id)
+ blobstore-map (storm-conf TOPOLOGY-BLOBSTORE-MAP)
+ user (storm-conf TOPOLOGY-SUBMITTER-USER)
+ topo-name (storm-conf TOPOLOGY-NAME)
+ user-dir (.getLocalUserFileCacheDir localizer user)
--- End diff --
'topo-name` and `user-dir` are unused.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
